This repository has been archived by the owner on Oct 31, 2023. It is now read-only.
Task computer "stuck" on subtask #4123
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
maaktweluit
commented
Apr 18, 2019
maaktweluit
force-pushed
the
mwu/no-subtask-id
branch
from
74c4f5f to
a1c0ca4
Compare
Wiezzel
reviewed
Apr 18, 2019
Wiezzel
reviewed
Apr 18, 2019
maaktweluit
force-pushed
the
mwu/no-subtask-id
branch
2 times, most recently
from
636c455 to
b2915b6
Compare
|
Rebased to develop now #4122 is solved |
|
@Wiezzel thanks for the review! Changed list to set and extended the tests, please check again :) |
tests/golem/task/test_taskkeeper.py
Outdated
| @@ -276,6 +276,7 @@ def test_task_limit(frozen_time, self): # pylint: disable=no-self-argument | |||
| self.assertIn(tb_id, tk.task_headers) | |||
|
|
|||
| def test_check_max_tasks_per_owner(self): | |||
There was a problem hiding this comment.
This test func got really long. Is it possible to split it?
Codecov Report
@@ Coverage Diff @@
## develop #4123 +/- ##
===========================================
+ Coverage 88.79% 88.79% +<.01%
===========================================
Files 215 215
Lines 18675 18694 +19
===========================================
+ Hits 16583 16600 +17
- Misses 2092 2094 +2 |
- Remove running tasks before counting
…ved log when removing tasks from one owner.
maaktweluit
force-pushed
the
mwu/no-subtask-id
branch
from
b979e5f to
fbe82fe
Compare
|
Duplicate of #4159 |
# for free
to subscribe to this conversation on GitHub.
Already have an account?
#.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
My golem node got stuck on a subtask:
When investigating i think the header was already deleted by the
check_max_tasks_per_owner()cleanup, while the task was computing:This PR solves it 2x:
task_computer, no longer return on error but let it clean up like other failures.task_keeperof what tasks are running, so they are not removed during cleanup.Blocked by: #4122 ( lint errors )